Re: iuu_phoenix-0.5.patch call for a last review/comment (I hope) this is the good one this time !
Oliver Neukum <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
Am Freitag 17 August 2007 schrieb [email protected]: > Summary of changes : > > - msleep in place of schedule_timeout. > - A iuu_clock removed because the function was called twice > > Many many Thx to Oliver and Alan for all precious comments to a dummy kernel > hacker. > > Alain > Almost, but you are still doing DMA to the stack: +/* Diables the IUU UART (a.k.a. the Phoenix voiderface) */ +static int iuu_uart_off(struct usb_serial_port *port) +{ + int status; + u8 buf = IUU_UART_DISABLE; + + status = bulk_immediate(port, &buf, 1); + if (status != IUU_OPERATION_OK) + dbg("%s - uart_off error", __FUNCTION__); + + return status; +} Regards Oliver ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel