Re: [patch 2.6.23-rc3 1/4] EHCI restart speedup
Geoff Levand <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
David Brownell wrote: > From: Marcelo Tosatti <[email protected]> > > It is not necessary to powerdown the ports on ehci_pci_reinit() when the > chip reset already did that. Removing this saves 20ms during restart > after poweroff paths (which OLPC uses a lot). > > To ensure driver startup then behaves consistently, force a reset during > driver startup. (Not doing this was an accident of some previous changes > to the init sequence.) > > Make the corresponding change in the PS3 support. It's not clear what > ehci-fsl should do here; it has similar code to the PS3. > > Signed-off-by: Marcelo Tosatti <[email protected]> > Signed-off-by: David Brownell <[email protected]> > Cc: [email protected] > Cc: [email protected] > --- > drivers/usb/host/ehci-pci.c | 5 +---- > drivers/usb/host/ehci-ps3.c | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) I tested this on PS3 with kernels both programed into flash, and booted via kexec. Seems to work OK. Acked-by: Geoff Levand <[email protected]> ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel