Re: [4/4] 2.6.23-rc3: known regressions
Linus Torvalds <[email protected]>
| Newsgroups | gmane.linux.usb.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 20 Aug 2007, Arjan van de Ven wrote:
>
> untested patch to add this to cpufreq; this is probably a good idea in
> general even if using the latency framework doesn't end up being used
> for fixing this regression...
>
>
> --- linux-2.6.23-rc2/drivers/cpufreq/cpufreq.c.org 2007-08-20 22:58:32.000000000 -0700
> +++ linux-2.6.23-rc2/drivers/cpufreq/cpufreq.c 2007-08-20 23:02:21.000000000 -0700
> @@ -1604,6 +1604,12 @@ static int __cpufreq_set_policy(struct c
> if (ret)
> goto error_out;
>
> +
> + if (system_latency_constraint() < policy->cpuinfo.transition_latency) {
That looks broken. "system_latency_constraint()" is in us, but
transition_latency is in ns, afaik.
But adding a "/ 1000" to turn the ns into us, and it migth even work.
Linus
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel