Re: [PATCH] USB: Driver for CH341 USB-serial adaptor

Oliver Neukum wrote:

 >> +       r = ch341_control_in(dev, 0x95, 0x0706, 0, buffer, size);
 >> +       /* return value ignored */
 >
 > Why is it ignored?
No doubt the USB device returns some useful status, but lacking a 
datasheet I do not know what it might be. The command is issued in the 
Windows driver, possibly with a good reason so I don't want to remove it.

 >> +out:   kfree(buffer);
 >
 > kfree() will take NULL, but that's not a reason to call it if you know
 > you have a NULL pointer.

OK, I'll add an error exit.
 >> +       r = ch341_configure(serial->dev, priv);
 >> +       if (r < 0)
 >> +               return r;

Yes, well spotted. Will fix that.

Thanks for your review comments,

Frank


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel