Re: [stable] [PATCH 16/35] usb-serial: fix oti6858.c segfault in termios handling

On Wed, Aug 22, 2007 at 11:52:57PM +0100, Alan Cox wrote:
> On Wed, 22 Aug 2007 15:15:32 -0700
> Greg Kroah-Hartman <[email protected]> wrote:
> 
> > From: Thomas Viehmann <[email protected]>
> > 
> > The oti6858 usb serial driver should use kernel_termios_to_user_termios/
> > user_termios_to_kernel_termios to avoid segfaults because the kernel
> > uses a structure differing from that of user space with a different
> > size.
> > 
> > Signed-off-by: Thomas Viehmann <[email protected]>
> > CC: stable <[email protected]>
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> 
> NAK
> 
> This is wrong, completely bogus and should be dropped. I've sent the
> correct fix (removing all the garbage) a couple of times, use that instead

Ick, yes, I'll queue that one up to fix this up properly.

Sorry, that fell through the cracks here somehow.

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel