Re: [PATCH 7/10] USB: Eliminate urb->status usage!
Alan Stern <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 24 Aug 2007, Greg KH wrote: > On Fri, Aug 24, 2007 at 03:42:24PM -0400, Alan Stern wrote: > > This patch (as979) removes the last vestiges of urb->status from the > > host controller drivers and the root-hub emulator. Now the field > > doesn't get set until just before the URB's completion routine is > > called. > > Wow, that is amazing! Thank you. It did end up taking longer than expected. Isn't that always how things work out... > Thanks a lot for doing all of this work. In the end, you saved a lot of > memory dropping that lock in the urb, and hopefully we can clean up all > of the drivers so that it is much harder for developers to do things > wrong in the future. > > Now I'll work on dropping the ->status usage from the remaining USB > drivers, before we change the urb callback function. That might be > something I can do while traveling in the next few weeks... There's still more changes to be made. My next job will be to remove all the "pipe" references from the HCDs, replacing them with the endpoint descriptors. That should be much more straightforward, although it will involve a lot of little changes. Alan Stern ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel