Re: [PATCH] Add Sony Ericsson P1i to unusual_devs.h

Greg,

Please apply the attached patch from Ricardo.

From: Ricardo Barberis <[email protected]>
Signed-off-by: Phil Dibowitz <[email protected]>

-------- Original Message --------
Subject: Re: [PATCH] Add Sony Ericsson P1i to unusual_devs.h
Date: Thu, 30 Aug 2007 15:24:04 -0300
From: Ricardo Barberis <[email protected]>
Organization: Dattatec.com
To: Phil Dibowitz <[email protected]>
CC: USB development list <[email protected]>
References: <[email protected]>
<[email protected]> <[email protected]>

El Jueves 30 Agosto 2007, Phil Dibowitz escribió:
> On Thu, Aug 30, 2007 at 02:42:01PM -0300, Ricardo Barberis wrote:
> > OK, I tested it at home with only US_FL_FIX_CAPACITY and didn't work.
> > Unfortunately I ddn't have time to recompile a second kernel with only
> > US_FL_IGNORE_RESIDUE, but this morning I tried it at work, and it did
> > work :)
>
> That's kinda what I suspected. US_FL_FIX_CAPACITY is for devices that
> report one more sector than they really have, and so you can crash the
> device by reading off the end of it. US_FL_IGNORE_RESIDUE is for devices
> that mis-report what they were and were unable to read, which would cause
> the issue you described.
>
> > I guess that would be sufficient, but I'll try the three ways at home
> > just in case (and to learn how to use gentoo's genkernel!!), and let you
> > know if you want me to.
>
> That would be great. If you'd like to generate a new patch, I'll ACK it...
> otherwise I'll gen one next week.

New patch attached, I'll report tomorrow when I test at home.

-- 
Ricardo Barberis
Senior SysAdmin - I+D
Dattatec.com - Hosting Solutions
http://www.dattatec.com


-- 
Phil Dibowitz                             [email protected]
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

--- linux-2.6.22.5/drivers/usb/storage/unusual_devs.h	2007-08-30 15:19:01.000000000 -0300
+++ linux-2.6.22.5-p1/drivers/usb/storage/unusual_devs.h	2007-08-30 15:19:31.000000000 -0300
@@ -1365,6 +1365,13 @@
 		US_SC_DEVICE, US_PR_DEVICE, NULL,
 		US_FL_FIX_CAPACITY | US_FL_IGNORE_RESIDUE ),
 
+/* Reported by Ricardo Barberis <[email protected]> */
+UNUSUAL_DEV(  0x0fce, 0xe092, 0x0000, 0x0000,
+		"Sony Ericsson",
+		"P1i",
+		US_SC_DEVICE, US_PR_DEVICE, NULL,
+		US_FL_IGNORE_RESIDUE ),
+
 /* Reported by Emmanuel Vasilakis <[email protected]> */
 UNUSUAL_DEV(  0x0fce, 0xe031, 0x0000, 0x0000,
 		"Sony Ericsson",

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG35IQN5XoxaHnMrsRAmlSAJ4wVWjeBmkxo2Kq1e5cj787WLkh+wCdHSIb
MwnPnFtFis4hk8EwkMl3gms=
=C6hL
-----END PGP SIGNATURE-----