Re: [PATCH 1/2] ELAN U132 Host Controller Driver: convert sw_lock to mutex

El Fri, Sep 07, 2007 at 09:22:19AM +0200 Oleg Verych ha dit:

> On Fri, Sep 07, 2007 at 08:14:11AM +0200, Matthias Kaehlcke wrote:
> []
> > > Subject: [PATCH 1/2] ELAN U132 Host Controller Driver: convert sw_lock to mutex
> > > []
> > > >          struct list_head u132_list;
> > > > -        struct semaphore sw_lock;
> > > > +        struct mutex sw_lock;
> > > >          struct semaphore scheduler_lock;
> > > 
> > > Subject: [PATCH 2/2] ELAN U132 Host Controller Driver: convert  scheduler_lock t
> > > []
> > > >         struct list_head u132_list;
> > > >         struct semaphore sw_lock;
> > > >-        struct semaphore scheduler_lock;
> > > >+        struct mutex scheduler_lock;
> > > 
> > > Are you sure, you have right patch sequence?
> > 
> > my idea was to sent two independent patches, would it be better to
> > have one patch based on the other?
> 
> They must be consecutive *and* not contradicting. This patches are
> mutually exclusive, because each includes unmodified context of other.

ok i understand, the problem is the context. sorry for my ignorance,
i'm going to sent out a new version of the second patch (convert
scheduler_lock) based on the first one

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

      In itself, homosexuality is as limiting as heterosexuality: the
     ideal should be to be capable of loving a woman or a man; either,
      a human being, without  feeling fear, restraint, or obligation
                          (Simone de Beauvoir)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel