Re: [patch 2.6.23-rc3 1/4] EHCI restart speedup
Greg KH <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Sep 12, 2007 at 12:01:52AM -0700, Geoff Levand wrote: > Geoff Levand wrote: > > David Brownell wrote: > >> From: Marcelo Tosatti <[email protected]> > >> > >> It is not necessary to powerdown the ports on ehci_pci_reinit() when the > >> chip reset already did that. Removing this saves 20ms during restart > >> after poweroff paths (which OLPC uses a lot). > >> > >> To ensure driver startup then behaves consistently, force a reset during > >> driver startup. (Not doing this was an accident of some previous changes > >> to the init sequence.) > >> > >> Make the corresponding change in the PS3 support. It's not clear what > >> ehci-fsl should do here; it has similar code to the PS3. > >> > >> Signed-off-by: Marcelo Tosatti <[email protected]> > >> Signed-off-by: David Brownell <[email protected]> > >> Cc: [email protected] > >> Cc: [email protected] > >> --- > >> drivers/usb/host/ehci-pci.c | 5 +---- > >> drivers/usb/host/ehci-ps3.c | 2 +- > >> 2 files changed, 2 insertions(+), 5 deletions(-) > > > > I tested this on PS3 with kernels both programed into flash, and > > booted via kexec. Seems to work OK. > > > > Acked-by: Geoff Levand <[email protected]> > > Hi Dave, > > I was expecting to see this go into 2.6.23, but it seems to be missing. > Could you let me know the status? It's in my queue to go into 2.6.24, I didn't realize that it was something needed for 2.6.23. If you want, I can queue it up to go into the first 2.6.23-stable release. thanks, greg k-h ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel