Re: [linux-usb-devel] question on flushing buffers and spinning down disk

On Fri, Sep 28, 2007 at 09:02:45AM +0200, Oliver Neukum wrote:
> Am Freitag 28 September 2007 schrieb Greg KH:
> > On Tue, Sep 25, 2007 at 05:11:00PM +0200, Oliver Neukum wrote:
> > > 
> > > PS: Whoever designed klists is suffering from a case of overengineeringosis.
> > 
> > No objection from me there. ?If you can think of a way to do list
> > traversal without taking locks, please, feel free to redo the whole
> > klist stuff.
> 
> No, I just was happy to be able to avoid using them.
> 
> But it is not just overengineered, it is also underengineered:
> 
> int bus_for_each_dev(struct bus_type * bus, struct device * start,
> 		     void * data, int (*fn)(struct device *, void *))
> 
> An interface should be designed to note where it fails, thus:
> 
> int bus_for_each_dev(struct bus_type * bus, struct device ** current,
> 		     void * data, int (*fn)(struct device *, void *))

You know that patches are always gladly accepted :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html