Re: Prolific 2501 link cable

> > Hi,
> >
> > i have created a working driver for prolifc pl2501/2302 bases link
> > cables. This driver does interoperate with the windows driver provided by
> > prolific. It would be great if someone can do some tests too. I tested it
> > on between kernel 2.6.15 and windows XP (SP2) (please turn off the
> > firewall if you have SP2).
> >
> > Please let me know if something is wrong with this driver.
> >
> > Regards
> >
> > Tobias
>
> 	// FIXME:  magic numbers, bleech
> 	padlen = (skb->len + (4  % 64)) ? 0 : 1;
>
> 4 % 64 is 4, always. So unless skb->len is -4, thus negative, this will
> always evaluate to 0. Something is fishy.

Right, that is an old part of the gl620a driver. This should be removed.

>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> [email protected]
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel