Re: [PATCH] OHCI: add PowerPC 440EP/440EPx support
"Dale Farnsworth" <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Oct 08, 2007 at 05:39:34PM +0000, Kumar Gala wrote: > On Oct 8, 2007, at 11:19 AM, David Brownell wrote: > > >>> Near as I can tell, the original code is wrong ... the hcca- > >>> >frame_no > >>> byte offset is fully specified, so that shift should always be 16. > >> > >> Are you saying that it should always be #define > >> OHCI_BE_FRAME_NO_SHIFT > >> 16 for big endian platforms? > > > > More than that, I'm saying that shouldn't even be a #define! The > > default should be that drivers expect chips to follow the interface > > specs. Any value other than 16 violates the OHCI spec. > > > > However, based on one other post, I suspect at least one Freescale > > part will need to declare a chip quirk for this case. > > Which Freescale part do you think needs this? When I originally did the big-endian ohci support, the IBM 40x (stb04xxx) and the Motorola, now Freescale, mpc5200 differed in the offset of the frame number. As far as I know, only the mpc5200 and derivatives need this chip quirk. -Dale ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel