Re: [PATCH] Try 3: Export URB statistics for powertop.

Hi Sarah,

> > > +static ssize_t
> > > +show_urbnum(struct device *dev, struct device_attribute *attr, char *buf)
> > > +{
> > > +	struct usb_device *udev;
> > > +
> > > +	udev = to_usb_device(dev);
> > > +	return sprintf(buf, "%d\n", atomic_read(&udev->urbnum));
> > > +}
> > > +static DEVICE_ATTR(urbnum, S_IRUGO, show_urbnum, NULL);
> > > +
> > 
> > some small comment on this one. I would have written it this way:
> > 
> > 	struct usb_device *udev = to_usb_device(dev);
> > 	return sprintf(....
> 
> I was following the coding style in the other functions in sysfs.c.
> Otherwise I would have done it that way too. :)

fair enough.

> On an unrelated note, aren't you the maintainer for the Linux bluetooth
> stack?  I was wondering if the rework of that code included autosuspend
> support for bluetooth devices.

I have a new driver that will replace hci_usb and only start the bulk
and ISOC URBs when they are needed. This will remove that driver from
your powertop list of bad drivers and will allow for testing autosuspend
and actually remote wakeup at some point.

However I am not sure how far we get with autosuspend and remote wakeup
since of these devices are particular bad ones and poorly engineered.

Regards

Marcel



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel