Re: [PATCH] Printer Gadget Driver v0.2.0 (kernel 2.6.21.3)
David Brownell <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sunday 07 October 2007, Craig W. Nadler wrote:
> +#define GADGET_GET_PRINTER_STATUS _IOR('P', 1, unsigned char)
> +#define GADGET_SET_PRINTER_STATUS _IOWR('P', 2, unsigned char)
I see that 'P' is already used in 2.6.23 (blackfin) ... can you
pick another code, or come up with some other scheme preventing
ioctl code collisions? Just let me know, I'll swap it in.
A related minor change: you didn't set up <linux/usb/g_printer.h>
to export, so your sample program wasn't able to use the
codes exported therein. Fixed.
- Dave
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel