Re: [PATCH] imx: add udc driver
David Brownell <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wednesday 10 October 2007, David Brownell wrote: > Also, this patch has around 400 checkpatch.pl problems, plus > space at end of line issues reported by "quilt". I didn't yet > check for compiler warnings, or "sparse" output. It doesn't compile, either... CC drivers/usb/gadget/imx_udc.o In file included from drivers/usb/gadget/imx_udc.c:74: drivers/usb/gadget/imx_udc.h: In function 'make_usb_disappear': drivers/usb/gadget/imx_udc.h:114: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:114: error: (Each undeclared identifier is reported only once drivers/usb/gadget/imx_udc.h:114: error: for each function it appears in.) drivers/usb/gadget/imx_udc.h:114: error: 'USB_FE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h: In function 'let_usb_appear': drivers/usb/gadget/imx_udc.h:119: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:119: error: 'USB_FE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h: In function 'dump_ep_stat': drivers/usb/gadget/imx_udc.h:179: error: implicit declaration of function 'USB_EP_STAT' drivers/usb/gadget/imx_udc.h:179: error: 'USB_SIP' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:179: error: 'USB_DIR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:179: error: 'USB_ZLPS' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:179: error: 'USB_FLUSH' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:179: error: 'USB_STALL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h: In function 'dump_ep_intr': drivers/usb/gadget/imx_udc.h:192: error: implicit declaration of function 'USB_EP_INTR' drivers/usb/gadget/imx_udc.h:192: error: 'USB_FIFO_FULL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:192: error: 'USB_FIFO_EMPTY' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:192: error: 'USB_FIFO_ERROR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:192: error: 'USB_FIFO_HIGH' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:192: error: 'USB_FIFO_LOW' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:192: error: 'USB_MDEVREQ' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:192: error: 'USB_EOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:192: error: 'USB_DEVREQ' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:192: error: 'USB_EOT' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h: In function 'dump_intr': drivers/usb/gadget/imx_udc.h:208: error: 'USB_INTR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_WAKEUP' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_MSOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_SOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_RES' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_SUSP' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_RESET_STOP' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_RESET_START' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_FRAME_MATCH' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:208: error: 'USB_CFG_CHG' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h: In function 'dump_ep_fstat': drivers/usb/gadget/imx_udc.h:226: error: implicit declaration of function 'USB_EP_FSTAT' drivers/usb/gadget/imx_udc.h:226: error: 'USB_FRAME_STAT' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:226: error: 'USB_ERR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:226: error: 'USB_UF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:226: error: 'USB_OF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:226: error: 'USB_FR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:226: error: 'USB_FULL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:226: error: 'USB_ALRM' undeclared (first use in this function) drivers/usb/gadget/imx_udc.h:226: error: 'USB_EMPTY' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_usb_disable': drivers/usb/gadget/imx_udc.c:85: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:85: error: 'USB_FE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:85: error: 'USB_AFE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_usb_gpio': drivers/usb/gadget/imx_udc.c:95: error: 'PB22_PF_USBD_RCV' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_usb_reset': drivers/usb/gadget/imx_udc.c:106: error: 'USB_ENAB' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:106: error: 'USB_RST' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:112: error: 'USB_DADR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:112: error: 'USB_CFG' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_download_conf': drivers/usb/gadget/imx_udc.c:124: error: 'USB_DADR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:124: error: 'USB_CFG' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:128: error: 'USB_DDAT' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:129: error: 'USB_BSY' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_init_intr': drivers/usb/gadget/imx_udc.c:174: error: 'USB_MASK' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:176: error: implicit declaration of function 'USB_EP_MASK' drivers/usb/gadget/imx_udc.c:176: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c:179: error: 'USB_MSOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:179: error: 'USB_SOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:179: error: 'USB_FRAME_MATCH' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:180: error: 'USB_INTR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:182: error: 'USB_DEVREQ' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:182: error: 'USB_EOT' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:182: error: 'USB_EOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:183: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c:187: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c: In function 'imx_init_ep': drivers/usb/gadget/imx_udc.c:207: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c:208: error: 'USB_FLUSH' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_init_fifo': drivers/usb/gadget/imx_udc.c:219: error: implicit declaration of function 'USB_EP_FCTRL' drivers/usb/gadget/imx_udc.c:219: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c:222: error: implicit declaration of function 'USB_EP_FALRM' drivers/usb/gadget/imx_udc.c:222: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c: In function 'imx_usb_enable': drivers/usb/gadget/imx_udc.c:229: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:229: error: 'USB_FE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:229: error: 'USB_AFE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_ep_empty': drivers/usb/gadget/imx_udc.c:234: error: 'USB_EMPTY' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_fifo_bcount': drivers/usb/gadget/imx_udc.c:239: error: 'USB_FIFO_BCOUNT' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_flush': drivers/usb/gadget/imx_udc.c:244: error: 'USB_FLUSH' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_force_stall': drivers/usb/gadget/imx_udc.c:253: error: 'USB_STALL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'ep0_chg_stat': drivers/usb/gadget/imx_udc.c:271: error: 'old' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'write_packet': drivers/usb/gadget/imx_udc.c:467: error: 'USB_ZLPS' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:493: error: 'USB_WFR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:497: error: implicit declaration of function 'USB_EP_FDAT0' drivers/usb/gadget/imx_udc.c:497: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c: In function 'ep0start': drivers/usb/gadget/imx_udc.c:538: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c: In function 'read_fifo': drivers/usb/gadget/imx_udc.c:591: error: 'USB_FR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:607: error: 'USB_EMPTY' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:638: error: 'USB_FRAME_STAT' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_ep_queue': drivers/usb/gadget/imx_udc.c:799: error: 'USB_MASK' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:799: error: 'USB_SOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'udc_hardinit': drivers/usb/gadget/imx_udc.c:1067: error: 'USB_INTR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1067: error: 'USB_RESET_STOP' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'usb_gadget_register_driver': drivers/usb/gadget/imx_udc.c:1108: warning: ignoring return value of 'device_add', declared with attribute warn_unused_result drivers/usb/gadget/imx_udc.c:1119: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result drivers/usb/gadget/imx_udc.c: In function 'handle_ep0': drivers/usb/gadget/imx_udc.c:1207: error: 'USB_DEVREQ' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1207: error: 'USB_MDEVREQ' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1222: error: implicit declaration of function 'USB_EP_FDAT' drivers/usb/gadget/imx_udc.c:1259: error: 'USB_INTR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1259: error: 'USB_EOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1269: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1269: error: 'USB_CMDOVER' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1288: error: 'USB_CMDERROR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1303: error: 'USB_MASK' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1303: error: 'USB_SOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_udc_irq': drivers/usb/gadget/imx_udc.c:1376: error: 'USB_INTR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1389: error: 'USB_SOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1390: error: 'USB_FRAME_MATCH' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1391: error: 'USB_MSOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1396: error: 'USB_CFG_CHG' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1405: error: 'USB_STAT' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1407: error: 'USB_STAT_CFG' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1408: error: 'USB_STAT_INTF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1409: error: 'USB_STAT_ALTSET' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1482: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1482: error: 'USB_CMDOVER' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1485: error: 'USB_MASK' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1488: error: 'USB_WAKEUP' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1499: error: 'USB_SUSP' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1510: error: 'USB_RES' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1517: error: 'USB_RESET_START' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1528: error: 'USB_RESET_STOP' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_udc_ctrl_irq': drivers/usb/gadget/imx_udc.c:1556: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c:1563: error: 'USB_DEVREQ' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1563: error: 'USB_MDEVREQ' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1566: error: 'USB_EOF' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1571: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c: In function 'imx_udc_bulk_irq': drivers/usb/gadget/imx_udc.c:1591: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c:1599: error: lvalue required as left operand of assignment drivers/usb/gadget/imx_udc.c: In function 'udc_proc_read': drivers/usb/gadget/imx_udc.c:1748: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1748: error: 'USB_STAT' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1748: error: 'USB_ENAB' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1748: error: 'USB_FRAME' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1748: error: 'USB_INTR' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1748: error: 'USB_MASK' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_udc_suspend': drivers/usb/gadget/imx_udc.c:1937: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1937: error: 'USB_FE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1937: error: 'USB_AFE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c: In function 'imx_udc_resume': drivers/usb/gadget/imx_udc.c:1942: error: 'USB_CTRL' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1942: error: 'USB_FE_ENA' undeclared (first use in this function) drivers/usb/gadget/imx_udc.c:1942: error: 'USB_AFE_ENA' undeclared (first use in this function) make[2]: *** [drivers/usb/gadget/imx_udc.o] Error 1 make[1]: *** [drivers/usb/gadget] Error 2 make: *** [drivers] Error 2 ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel