Re: [PATCH]missing EOLs in cdc acm error reporting

Am Donnerstag 11 Oktober 2007 schrieb Alan Stern:
> On Thu, 11 Oct 2007, Oliver Neukum wrote:
> 
> > Hi,
> > 
> > some messages are missing newlines.
> > 
> > 	Regards
> > 		Oliver
> > 
> > Signed-off-by: Oliver Neukum <[email protected]>
> > 
> > ----
> > 
> > --- linux-2.6.23-rc9/drivers/usb/class/cdc-acm.c	2007-10-11 13:04:42.000000000 +0200
> > +++ acm/drivers/usb/class/cdc-acm.c	2007-10-11 13:04:56.000000000 +0200
> > @@ -866,7 +866,7 @@ static int acm_probe (struct usb_interfa
> >  		switch (buffer [2]) {
> >  			case USB_CDC_UNION_TYPE: /* we've found it */
> >  				if (union_header) {
> > -					err("More than one union descriptor, skipping ...");
> > +					err("More than one union descriptor, skipping ...\n");
> 
> You probably don't want to make these changes.  The err() macro 
> automatically appends a newline to the end of the format string.
> 
> Alan Stern
> 
> 

OK, thanks.

Greg, please disregard this. Why did I get a complaint then? Maybe I am using
a pure printk.

	Regards
		Oliver


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel