[patch]missing error check in emi26
Oliver Neukum <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi, this drivers lacks an error check. Regards Oliver Signed-off-by: Oliver Neukum <[email protected]> ---- --- linux-2.6.24-rc1/drivers/usb/misc/emi26.c.alt 2007-10-25 14:10:45.000000000 +0200 +++ linux-2.6.24-rc1/drivers/usb/misc/emi26.c 2007-10-25 14:11:55.000000000 +0200 @@ -114,6 +114,10 @@ static int emi26_load_firmware (struct u /* De-assert reset (let the CPU run) */ err = emi26_set_reset(dev,0); + if (err < 0) { + err("%s - error loading firmware: error = %d", __FUNCTION__, err); + goto wraperr; + } msleep(250); /* let device settle */ /* 2. We upload the FPGA firmware into the EMI ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel