Re: [patch] USB: kill bogus file in /sys/module/nousb/parameters

On Thu, Oct 25, 2007 at 03:02:34PM -0400, Chuck Ebbert wrote:
> On 10/25/2007 02:50 PM, Greg KH wrote:
> > On Fri, Oct 19, 2007 at 02:38:30PM -0400, Chuck Ebbert wrote:
> >> When USB is builtin, a file with a zero-length name is getting created in
> >> /sys/module/nousb/parameters and it's causing problems for programs that
> >> scan the filesystem. Since the file can't be read, statted, or anything,
> >> don't create it at all.
> >>
> >> Signed-off-by: Chuck Ebbert <[email protected]>
> > 
> > Hm, I don't see this at all.
> > 
> > On a machine with usbcore built in, I have no "nousb" paramater in the
> > usbcore directory:
> > 	$ ls -l /sys/module/usbcore/parameters/
> > 	total 0
> > 	-rw-r--r-- 1 root root 4096 Oct 25 11:46 autosuspend
> > 	-rw-r--r-- 1 root root 4096 Oct 25 11:46 use_both_schemes
> > 
> > And on a box with it built as a module:
> > 	$ ls -l /sys/module/usbcore/parameters/
> > 	total 0
> > 	-rw-r--r-- 1 root root 4096 Oct 25 11:52 autosuspend
> > 	-r--r--r-- 1 root root 4096 Oct 25 11:52 blinkenlights
> > 	-r--r--r-- 1 root root 4096 Oct 25 11:52 nousb
> > 	-rw-r--r-- 1 root root 4096 Oct 25 11:52 old_scheme_first
> > 	-rw-r--r-- 1 root root 4096 Oct 25 11:52 usbfs_snoop
> > 	-rw-r--r-- 1 root root 4096 Oct 25 11:52 use_both_schemes
> > 
> > It's a real paramater.
> > 
> > 
> > As for showing up in /sys/module/nousb/ on both machines:
> > 	$ ls /sys/module/n*
> > 	ls: cannot access /sys/module/n*: No such file or directory
> > 
> > it's not there.
> > 
> > I thought I had seen this sometime in the past, but I can't duplicate it
> > at all anymore, so is this still an issue?
> > 
> 
> No, it's fixed in 2.6.24-rc1 by commit faf8c714f4508207a9c81cc94dafc76ed6680b44
> which fixed the real underlying problem.

Ah, thanks, I'll drop this then :)

Do we want that commit in the -stable tree?

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel