Re: [PATCH] Fix priority mistakes in drivers/usb/core/hub.c

On Fri, 26 Oct 2007, Roel Kluin wrote:

> Fixes priority mistakes similar to '!x & y'

Actually it's a use of the wrong operator (or a typo, depending on how 
you look at it), not a priority mistake.

> Signed-off-by: Roel Kluin <[email protected]>
> ---
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 60a8f55..b64309e 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -335,7 +335,7 @@ static void kick_khubd(struct usb_hub *hub)
>  	to_usb_interface(hub->intfdev)->pm_usage_cnt = 1;
>  
>  	spin_lock_irqsave(&hub_event_lock, flags);
> -	if (!hub->disconnected & list_empty(&hub->event_list)) {
> +	if (!hub->disconnected && list_empty(&hub->event_list)) {
>  		list_add_tail(&hub->event_list, &hub_event_list);
>  		wake_up(&khubd_wait);
>  	}

Acked-by: Alan Stern <[email protected]>


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel