Re: Problem: usb-serial: parity mark,space ?
Roland Koebler <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <20071029223734.GA26888@localhost> |
hi again, > I noticed that nearly all usb-serial-adapters support mark and space > parity, but unfortunately nearly none of the linux-usb-serial-drivers > supports them. in addition to this, most of the drivers not only don't support mark/space parity, but *silently ignore it*. If you tell the driver to use mark/space parity, it accepts this setting, but then uses odd/even parity!! such a driver should: - either correctly support mark/space parity - or refuse this setting. everything else is a BUG. here's the short bugreport: 1. wrong parity-handling in usb-serial-drivers 2. most usb-serial-drivers ignore mark/space parity and silently use odd/even parity instead, because they ignore the CMSPAR bit in termios->c_cflag. X. fix: check CMSPAR in every driver. either support it or return an error if mark/space parity is requested. I'll submit a patch for the ftdi_sio usb-serial-driver (adding mark/space parity). and maybe I'll submit some patches for the other drivers rejecting mark/space parity. regards, Roland ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel