Re: [PATCH 2/2] [RFC] pl2303 autosuspend

Am Dienstag 30 Oktober 2007 schrieb Sarah Sharp:
> I'll play around with remote wakeup with my pl2303 converters and see
> what I can deduce.  I don't really know if allowing remote wake up is
> useful.  If we've autosuspended the serial converter because all ttys
> are closed, then no one cares about output from the device on the
> other end.  Forcing a wakeup from system suspend might be a useful
> thing, or waking up the converter to provide power to a device, but
> really I'm just making guesses about the usage model. :)

Wake on Ring?

> > So, does this patch work for you with your devices?
> 
> My devices work fine after an autosuspend, but I think they won't work
> after a suspend.  The urbs will get killed in the suspend function and
> then won't get resubmitted in the resume function.  You don't notice in
> the autosuspend case because the urbs are submitted when the tty is
> opened.  So this patch not ready to be merged; I simply wanted comments
> on it.

True, there is a use of the genric function misssing. Does it work with this
patch?

	Regards
		Oliver

Signed-off-by: Oliver Neukum <[email protected]>

----

--- linux-2.6.24-rc1/drivers/usb/serial/usb-serial.c.alt	2007-10-30 13:38:10.000000000 +0100
+++ linux-2.6.24-rc1/drivers/usb/serial/usb-serial.c	2007-10-30 13:38:47.000000000 +0100
@@ -1249,6 +1249,7 @@ static void fixup_generic(struct usb_ser
 	set_to_generic_if_null(device, read_bulk_callback);
 	set_to_generic_if_null(device, write_bulk_callback);
 	set_to_generic_if_null(device, shutdown);
+	set_to_generic_if_null(device, resume);
 }
 
 int usb_serial_register(struct usb_serial_driver *driver) /* must be called with BKL held */

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel