Re: [2.6 patch] usb/serial/oti6858.c: cleanups
Oliver Neukum <[email protected]>
| Newsgroups | gmane.linux.usb.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
Am Montag 05 November 2007 schrieb Adrian Bunk: > This patch containsthe following cleanups: > - make the needlessly global send_data() static > - an author without anemail address is OK, not a FIXME That should be up to the author. If he thinks it should be there it might be worth a FIXME > - directly put the IDs into the id_table Why? > - remove the now-empty oti6858.h > - kill the pointless driver version number Why? There might be a new version in the future. If the author put it there he might have had his reasons. Regards Oliver ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel