Re: device struct bloat

Peter Zijlstra <[email protected]>
Newsgroups gmane.linux.usb.devel,gmane.linux.kernel
Message-ID <1194342222.6544.20.camel@twins>
On Mon, 2007-11-05 at 17:38 -0800, David Brownell wrote:
> On Monday 05 November 2007, Greg KH wrote:
> > --- linux-2.6-2.orig/drivers/spi/spi.c
> > +++ linux-2.6-2/drivers/spi/spi.c
> 
> It'd be quicker to end up in the right hands if you had
> split this big and random patch according to subsystem...

Yeah, sorry, I just started converting mindlessly and stopped once it
compiled (which explains the missing FW bits, I don't have that in my
config). Then booted and fixed up what broke, well aside from the final
lockdep issue. As I couldn't get that fixed, I never looked twice,
didn't make it a proper patch-set, nor validated the rest of the patch.

Wasn't even planning on sending it out initially.

> There's already a patch in the MM queue that removes
> the SPI-private semaphore.  Except that it's missing
> the bug noted below.

Right, lack of a recent -mm made me work against mainline. I'm sure I
would've noticed otherwise :-)


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.