Re: [PATCH] Unbreak fsl_usb2_udc

On Tuesday 06 November 2007, Peter Korsgaard wrote:
> Commit a4e3ef5... (USB: gadget: gadget_is_{dualspeed,otg} predicates and
> cleanup) broke fsl_usb2_udc. udc->gadget is a struct usb_gadget, not a
> pointer to one.
> 
> Signed-off-by: Peter Korsgaard <[email protected]>

ACK.

Sorry about that.  What seems to have happened is that I did the
test builds against all the gadget drivers, but no peripheral
controller was involved.  Patches for the two affected ones have
now been submitted to Greg.  (The other was omap_udc.)


> ---
>  drivers/usb/gadget/fsl_usb2_udc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/fsl_usb2_udc.c b/drivers/usb/gadget/fsl_usb2_udc.c
> index 9bb7f64..038e7d7 100644
> --- a/drivers/usb/gadget/fsl_usb2_udc.c
> +++ b/drivers/usb/gadget/fsl_usb2_udc.c
> @@ -1318,7 +1318,7 @@ static void setup_received_irq(struct fsl_udc *udc,
>  				| USB_TYPE_STANDARD)) {
>  			/* Note: The driver has not include OTG support yet.
>  			 * This will be set when OTG support is added */
> -			if (!gadget_is_otg(udc->gadget))
> +			if (!gadget_is_otg(&udc->gadget))
>  				break;
>  			else if (setup->bRequest == USB_DEVICE_B_HNP_ENABLE)
>  				udc->gadget.b_hnp_enable = 1;
> -- 
> 1.5.3.4
> 
> -- 
> Bye, Peter Korsgaard
> 



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel