Re: [PATCH] ehci-hcd: complete iso urbs ASAP for number_of_packets != (n * 8) also

On Wednesday 07 November 2007, Karsten Wiese wrote:
> 
> Upstream (as of 2.6.23) ehci-hcd only completes iso urbs, if the last frame
> (= 8 uframes) they overlapped with has elapsed. That can be as late as when
> the following urb emits its interrupt on completion.
> soundcard drivers tend to work around by only transfering iso urbs with
> number_of_packets = (n * 8).
> Patch lets iso urbs complete asap by scanning itd always up to the elapsed
> uframe. An itd's last scanned uframe is stored in the new struct ehci_itd
> member uframe_scanned.
> Itds stay kept in the hcd's schedule until the complete frame they cover
> has elapsed, like without patch.
> To make this possible, ehci->periodic_sched is changed based on the number of
> active itds instead of the number of active iso urbs.

Looks interesting, but could you make this apply to *BOTH* types of
ISO transfer descriptor?  You did it for ITDs, but not Split-ITDs.

Plus there are two non-technical problems with this patch.  First,
it doesn't apply against 2.6.24-rc2-git; second, it triggers lots
of messages from scripts/checkpatch.pl ... both issues need to get
fixed before I can properly review this.

- Dave

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel