Re: usb function framework

On Mon, Nov 12, 2007 at 02:22:15PM -0600, Felipe Balbi wrote:
> Hi,
> 
> On Mon, 12 Nov 2007 12:04:50 -0800, Greg KH <[email protected]> wrote:
> > Hi,
> > 
> > In poking around the newly released "Android" kernel git tree:
> > 	http://git.android.com/
> > 
> > I noticed that you checked in a rather large "usb function framework"
> > chunk of code.
> > 
> > As this is competing directly with the current in-kernel usb gadget
> > framework, it seems strange to me that you did not come and try to work
> > with the Linux kernel community about your issues with the current
> > codebase.
> > 
> > What is wrong with the current gadget framework that resulted in this
> > rewrite?  I'm sure that we would be glad to work with you to prevent
> > such duplicated effort, especially one that is probably ensured to never
> > make it into the main kernel tree due to the duplicated functionality.
> 
> Quoting Dave Brownell, the best way to do this would be re-factoring g_*
> modules into usb function drivers and creating a glue module on top of
> it to reuse the code and factor them together creating a composite
> device.

Ok, that makes sense.  But is that what this new framework really is:
	http://git.android.com/?p=linux-msm.git;a=commitdiff;h=7c334047893eb59ff47d29f16b35bdcd17d20e07

?

If so, Brian, care to send me and David and the linux-usb-devel mailing
list a patch so that we can review this and see if it will work
properly?

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel