Re: usb function framework
Brian Swetland <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Organization | Google, Inc. |
| Message-ID | <20071112203936.GB21473@bulgaria> |
[Greg KH <[email protected]>] > On Mon, Nov 12, 2007 at 02:22:15PM -0600, Felipe Balbi wrote: > > On Mon, 12 Nov 2007 12:04:50 -0800, Greg KH <[email protected]> wrote: > > > In poking around the newly released "Android" kernel git tree: > > > http://git.android.com/ > > > > > > I noticed that you checked in a rather large "usb function framework" > > > chunk of code. > > > > > > As this is competing directly with the current in-kernel usb gadget > > > framework, it seems strange to me that you did not come and try to work > > > with the Linux kernel community about your issues with the current > > > codebase. > > > > Quoting Dave Brownell, the best way to do this would be re-factoring g_* > > modules into usb function drivers and creating a glue module on top of > > it to reuse the code and factor them together creating a composite > > device. > > Ok, that makes sense. But is that what this new framework really is: > http://git.android.com/?p=linux-msm.git;a=commitdiff;h=7c334047893eb59ff47d29f16b35bdcd17d20e07 > > ? > > If so, Brian, care to send me and David and the linux-usb-devel mailing > list a patch so that we can review this and see if it will work > properly? I'm a little swamped this next week or two (sdk launch, trying to get core MSM7K support in reasonable shape), but I'd certainly be interested in discussing this further soon. If the gadget framework could provide the ability to bolt-together composite devices from reusable function components, that'd be a large part of the way towards what we're hoping for. I think my other complain with gadget is just figuring out exactly what the "rules" for device controller drivers implementing the interface are. I looked at a couple different ones and was unclear on what context various things are called from, etc. I could take some time and assemble some coherent notes on things that were a bit frustrating to work with sometime. Brian ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel