Re: [PATCH] SCSI error handling on some USB disks needs allow_restartcp

On Tue, Nov 13, 2007 at 11:28:54PM +0100, Jean Delvare wrote:
> On Tue, 13 Nov 2007 11:57:59 -0500 (EST), Alan Stern wrote:
> > On Tue, 13 Nov 2007, Matthew Dharm wrote:
> > 
> > > On Tue, Nov 13, 2007 at 03:41:21PM +0100, Jean Delvare wrote:
> > > > > +	vendor = us->pusb_dev->manufacturer;
> > > > > +	product = us->pusb_dev->product;
> > > > > +
> > > > > +	if (vendor && product &&
> > > > > +	    !strcmp(vendor, "Seagate") &&
> > > > > +	    (!strcmp(product, "FreeAgent Pro") ||
> > > > > +	     !strcmp(product, "FreeAgentDesktop")))
> > > > > +		sdev->allow_restart = 1;
> > > > > +
> > > > >   	/*
> > > > >   	 * The UFI spec treates the Peripheral Qualifier bits in an
> > > > >   	 * INQUIRY result as reserved and requires devices to set them
> > > 
> > > This is overkill.  It's almost certainly safe to just set allow_restart = 1
> > > always, since the SCSI layer won't send a START_STOP unless it gets an
> > > error, anyway.
> > > 
> > > Long ago, every device got a START_STOP, and a lot of them broke.  But now,
> > > the devices that can't tollerate a START_STOP shouldn't trigger those code
> > > paths.
> > 
> > Right.  In fact the patch has already been written.  See
> > 
> > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-03-usb/usb-storage-always-set-the-allow_restart-flag.patch
> 
> Ah, great. This is very fine with me.
> 
> Greg, any reason to not push this patch to Linus before 2.6.24? It
> fixes real-world issue.

I was not aware that it was needed for .24.  If Matthew and Alan think
it should go in, I have no objection, but I need their ok to do so.

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel