Re: [PATCH] SCSI error handling on some USB disks needs allow_restartcp

On Tue, Nov 13, 2007 at 03:09:03PM -0800, Greg KH wrote:
> On Tue, Nov 13, 2007 at 03:03:48PM -0800, Matthew Dharm wrote:
> > On Tue, Nov 13, 2007 at 02:44:01PM -0800, Greg KH wrote:
> > > On Tue, Nov 13, 2007 at 11:28:54PM +0100, Jean Delvare wrote:
> > > > Greg, any reason to not push this patch to Linus before 2.6.24? It
> > > > fixes real-world issue.
> > > 
> > > I was not aware that it was needed for .24.  If Matthew and Alan think
> > > it should go in, I have no objection, but I need their ok to do so.
> > 
> > 'Need' is a strong word.  As far as I can tell, there are exactly 2 models
> > of device out there which don't work without this patch.
> > 
> > I really would rather see it merged into an -mm tree, or something that
> > gets widespread testing, before mainlining.
> 
> It's been in the -mm tree for a few releases now.  Although if this is a
> very uncomon device, the few -mm testers might not have run into it.

I'm more concerned with not breaking every *other* device out there.  A lot
of them are sensitive to START_STOP, but sd_mod and the SCSI core have been
rewritten over time to use it a *lot* less.

If it's been in -mm for a while, let's push it to mainline.

Matt

-- 
Matthew Dharm                              Home: [email protected] 
Maintainer, Linux USB Mass Storage Driver

We've made a business out of making money from annoying and stupid people.
I think you fall under that category.
					-- Chief
User Friendly, 7/11/1998

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQFHOjnwHL9iwnUZqnkRArHOAKCQavblzI0IxUO0rg66PUpAA7ZzJgCaApRv
iVzD81ZXPmPzF54/Xq6lqI4=
=swKn
-----END PGP SIGNATURE-----