Re: RFC: ti_usb-serial: userspace firmware, internal cfg. change, cleanup

On Wed, Nov 14, 2007 at 04:47:55PM +0100, Oleg Verych wrote:
> Al, Greg.
> 
> This is all-in-one patch for show.

Please run this through scripts/checkpatch.pl first and fix all of those
warnings.

Also, please split up the whitespace changes from the real changes so
that it is easier to review what is actually changed here.

> o  File 'tiusb3410.i51' or  'tiusb5052.i51' is being requested from the
>    userspace, usually '/lib/firmware/'.

Where does this file come from?  Is it shipped by TI anywhere?

> o  Reconfiguration is done internally.
> 
> o  kmalloc() isn't used for copying-copying of the binary. Optimistic
>    allocation always requires 4 pages for maximum 16k of data.

What does this help with?

> o  git-nuke ti_fw_3410.h ti_fw_5052.h
> 
> o  Base Linux version is 2.6.22 with Oliver's 'usb-serial.c' fix. Tested
>    with addition of pl2303-based cabel.

Can you please base this on 2.6.24-rc2, there's not much we can do with
patches for 2.6.22.

What does pl2303 have to do with this driver?

Please do not #define usb, that's ripe for confusion.

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel