Re: [patch 19/26] USB: mutual exclusion for EHCI init and port resets
David Miller <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
From: David Brownell <[email protected]> Date: Mon, 19 Nov 2007 11:59:55 -0800 > > This addition certainly won't hurt. Did we ever get any feedback as to > > whether it actually helped? > > ISTR that davem refused to try it, after reporting an > intermittent failure on the original patch (which only > addresses one end of that hardware race). > > So, no ... but given we know that closing only one side > of the race isn't quite enough, I think we need it anyway. I think we should put all these changes in because at a minimum it's a step in the right direction even if it doesn't close the hole %100. So please let's merge the mutex and the msleep() change in ASAP, thanks.