Re: [PATCH] USB: m66592-udc: Add support for SH7722 USBF

On Fri, Nov 09, 2007 at 05:35:44PM +0900, Yoshihiro Shimoda wrote:
> David Brownell wrote:
> > On Thursday 08 November 2007, you wrote:
> >> David Brownell wrote:
> >>> ACK ... though see below.
> >>>
> >>> And I suspect you're missing clock management for the on-chip code,
> >>> and assuming that "someone else" turns on the clocks needed by this
> >>> particular functional module.  Since this all seems quite new, I'd
> >>> expect such patches to show up later.
> >> Thank you for your comment.
> >>
> >> I already sent a patch which turned on clock of USBF to SuperH maintainer.
> >>    http://lkml.org/lkml/2007/11/2/10
> >>    sh: Enable USBF on MS7722SE.
> >
> > That's the wrong model, except when powere management is a
> > complete non-issue.  The probe() and resume() methods will
> > normally turn the clock(s) off.  The suspend() and remove()
> > methods will normally turn them off.  If some non-retention
> > mode is supported, there are ways to us that too.
> >
> > Plus, when there's no VBUS current available, that's another
> > signal to put the controller into a low power mode ... which
> > usually means "clocks off", including whatever goes to the
> > high speed PHY.
> 
> I understood it. I do not think that power management is
> a non-issue. I made a patch which I added clock management.
> But my development environment does not support suspend()
> and resume(), so suspend() and resume() methods of this
> driver did not implement it.
> 
> >>> But the Kconfig BUILT_IN_* option is defined only if this
> >>> CPU_SUBTYPE is set.  I take it the implication is that
> >>> other similar chips are on the way, and only this one
> >>> requires that workaround?
> >> Perhaps this workaround is necessary for only this CPU.
> >> But I can not confirm it whether it is really necessary
> >> or not, because I do not yet obtain other similar CPU's.
> >
> > In which case that nested #ifdef should probably vanish.
> 
> I see. I removed it.
> 
> Thanks,
> Yoshihiro Shimoda
> 
> ---
> 
>  drivers/usb/gadget/m66592-udc.c |   29 ++++++++++++++++++++++-------
>  drivers/usb/gadget/m66592-udc.h |   20 ++++++++++++++++++++
>  2 files changed, 42 insertions(+), 7 deletions(-)

Can you send me a new version of this, with the proper changelog and
signed-off-by lines?

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel