Re: [PATCH 1/1] Enable autosuspend for pl2303 USB to serialconverters.

On Tue, Nov 27, 2007 at 09:00:09AM -0800, Sharp, Sarah A wrote:
> >Greg K-H wrote:
> >On Tue, Nov 13, 2007 at 05:10:14PM -0800, Sarah Sharp wrote:
> >> The HX type pl2303 chip handles suspend gracefully, but the 
> >> type_1 chip does not.
> >
> >I don't want to apply a patch that we know is broken for a very large
> >set of working-right-now devices.
> 
> The only new thing this patch would break is autosuspend for the type_1
> chip.

Right, which is what this patch now allows to have happen for this
device :)

> Suspend for the chip was already broken.  Oliver and Alan suggested
> adding a reset resume quirk for this chip, so I need to try that
> before this patch is applied.
> 
> >Hm, but your patch does not handle this distinction.
> >
> >As the driver does know the difference between the device types,
> >shouldn't it be able to handle this?
> 
> If a reset resume doesn't help, the driver could refuse to autosuspend
> the type_1 chip.  But what about refusing during system suspend or
> hibernate?
> Should a system suspend be stopped because one device can't handle
> suspend?

Hm, can we fall back on the "disconnect the device" type of
functionality for devices like this if they fail to suspend properly?

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel