Re: [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)
Greg KH <[email protected]>
| Newsgroups | gmane.linux.usb.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: > (resending .. somebody trimmed the CC: list earlier) > > Greg KH wrote: >>>>> Mark Lord wrote: >>>>>> .. >>>>>> >>>>>> While doing insert/remove (quickly) tests on USB, >>>>>> I managed to trigger an Oops on 2.6.23.8 on a call >>>>>> to strlen() in make_class_name(). > ... > >> I'll hold off on adding this patch for now. > .. > > Why? > > Bugs that result in Oops in core code (class.c) can bite > just about any subsystem that does hotplug, and should get > prompt attention. Or so one might think. And they have, the 2.6.24 kernel should have the correct fix for this problem, right? The fact that you oopsed out in this function enabled people to find and fix the problem already. Adding a BUG_ON() does the same exact thing :) So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. Don't add code to lower layers to paper over bugs elsewhere. thanks, greg k-h ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel