Re: [PATCH 1/1 resend] usb-storage: limit devices that cannot handle 32k transfers

Doug Maxey wrote:
>>From f644b337771374178d5585bcedf8153f5b45f2d6 Mon Sep 17 00:00:00 2001
> From: Doug Maxey <[email protected]>
> Date: Tue, 27 Nov 2007 18:42:42 -0600
> Subject: [PATCH 1/1] usb-storage: limit devices that cannot handle 32k transfers
> 
> When a device cannot handle the smallest previously limited transfer
> size (64 blocks) without stalling, limit the device to the amount of
> packets that fit in a platform native page.
> 
> The lowest possible limit is PAGE_CACHE_SIZE, so if the device is ever
> used on a platform that has larger than 8K pages, you lose unless you
> can convince the device firmware folks to fix the issue.
> 
> Cc: Mathew Dharm <[email protected]>
> Cc: Alan Stern <[email protected]>
> Cc: Pete Zaitcev <[email protected]>
> Signed-off-by: Doug Maxey <[email protected]>

Short of the weird spacing issues in usb_usual.h, it looks fine to me, and
I'll sign off on it since I wrote the original US_FL_MAX_SECTORS_64 patch if
I recall correctly.

Signed-off-by: Phil Dibowitz <[email protected]>

-- 
Phil Dibowitz                             [email protected]
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHZbIxN5XoxaHnMrsRApZ0AKCQstds+7Hzt2k3mNfIcXEr0MSAogCeOFja
QEtsVC4DY7F9YK2akpo+CNE=
=NJjX
-----END PGP SIGNATURE-----