Re: [Bugme-new] [Bug 9594] New: Dereferencing NULL pointer on drivers/usb/gadget/ether.c
David Brownell <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
> > http://bugzilla.kernel.org/show_bug.cgi?id=9594 > > > > ... > > > > The potential error can be tracked down as follows: > > > > (1) line 1050: let the second conjunct on the "if" statment be false > > meaning "dev->status_ep" is null. This means the "if" evaluates to false. I'm guessing this is really line 1020 at the top of set_ether_config(), in the current kernel. Because line 1050 has nothing to do with status_ep. > > follow thru the code until... > > > > (2) line 1101: usb_ep_disable(dev->status_ep) passes in a null argument, > > however "use_ep_disable" cannot handle that: And I'm assuming that's 51 lines later, the "on error..." path. As we know, no errors happen hence all error paths work Just Fine. ;) Another way to put this diagnosis is that the same test needs to be used in both places, else it's overkill in one of them. ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel