Re: [PATCH v2 2/4] USB: add Cypress c67x00 OTG controller core driver

Hi Grant,

Just one nit ...

On Fri, 28 Dec 2007 16:52:36 -0700 Grant Likely <[email protected]> wrote:
>
> +static int __devinit c67x00_drv_probe(struct platform_device *pdev)
> +{
> +	struct c67x00_device *c67x00;
> +	struct c67x00_platform_data *pdata;
> +	struct resource *res, *res2;
> +	int ret, i;
> +
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -ENODEV;
> +
> +	res2 = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> +	if (!res2)
> +		return -ENODEV;
> +
> +	pdata = (struct c67x00_platform_data*)pdev->dev.platform_data;

This cast is unnecessary.

-- 
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHdeghTgG2atn1QN8RAp2MAKCPYuqWm4uPI+ijLr1ENLRk0G/IvgCffLrK
p10+rYn3uJp1wvfV4YeC0P4=
=/tSF
-----END PGP SIGNATURE-----