Re: [PATCH] USB: add support for SuperH OHCI

On Thursday 10 January 2008, Yoshihiro Shimoda wrote:
> +static int ohci_hcd_sh_probe(struct platform_device *pdev)
> +{
> +       int ret;
> +
> +       if (usb_disabled())
> +               return -ENODEV;
> +
> +       ret = usb_ohci_sh_probe(&ohci_sh_hc_driver, pdev);

Could you have just one probe() routine ...


> +       return ret;
> +}
> +
> +static int ohci_hcd_sh_remove(struct platform_device *pdev)
> +{
> +       struct usb_hcd *hcd = platform_get_drvdata(pdev);
> +
> +       usb_ohci_sh_remove(hcd, pdev);

... and one remove() routine, instead?

Splitting it up like that is an old idiom I'd rather see disappear.

- Dave


> +       return 0;
> +}
> +



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel