Re: [PATCH][3/4] usb: ohci-sm501 driver

> +static int ohci_hcd_sm501_drv_probe(struct platform_device *dev)
> +{
> +	return usb_hcd_sm501_probe(&ohci_sm501_hc_driver, dev);
> +}
> +
> +static int ohci_hcd_sm501_drv_remove(struct platform_device *dev)
> +{
> +	struct usb_hcd *hcd = platform_get_drvdata(dev);
> +
> +	usb_hcd_sm501_remove(hcd, dev);
> +	platform_set_drvdata(dev, NULL);
> +
> +	return 0;
> +}

I'll repeat the feedback I've given to some other OHCI drivers
recently.

That "two probe routines" idiom needs to die.  Fix it so there
is only one probe() routine, and one remove() routine.

- Dave


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel