Re: [PATCH][3/4] usb: ohci-sm501 driver

On Sunday 13 January 2008, Magnus Damm wrote:
> usb: ohci-sm501 driver
> 
> This patch adds sm501 ohci support.

Just sm501, not the sm502 you had mentioned?


> It's all very straightforward with the 
> exception of dma_declare_coherent_memory() and HCD_BOUNCE.

If I skimmed those docs right, sm502 won't always need that.

For example, if the sm502 is hooked up through PCI, it doesn't
necessarily even need to have local memory ... or use it for
OHCI, if it's present.  (Certainly there's a DMA controller
on the chip that can do PCI bus mastering.  I'm assuming that
the OHCI silicon is hooked up to that controller...)

If that's so, that stuff should be a function of how the
platform device was configured.  For example, an sm502 on
a PCI card might set up a bunch of platform devices for
its various functions (assuming they don't show up as normal
functions) ... but without memory resource #1, thereby
signaling that it doesn't need to use local memory or
do the dma_alloc_coherent() dance.


> Together they 
> are used to ensure that usb data is allocated using dma_alloc_coherent(),
> and that only valid dma memory is used to allocate from. This driver is
> a platform device, and the mfd driver sm501.c is already creating one
> usb host controller instance per sm501.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel