Re: [PATCH] UWB: i1480: disable MAC/PHY information checking

On Tuesday 24 June 2008, David Vrabel wrote:
> Anderson Lizardo wrote:
> > Some hardware/firmware combinations (most notably an IOGear HWA using the i1480
> > firmware) kill the host controller after issuing a GET_MAC_PHY_INFO command.
> > Disabling this check seems harmless otherwise.
> > 
> > The patch fixes the issue where the HC is killed, showing the message:
> > 
> > ehci_hcd 0000:00:1d.7: HC died; cleaning up
> > 
> > After this error, USB comes back only after reloading the ehci_hcd module.
> 
> If this is going to always be disabled, why not remove the call to
> GET_MAC_PHY_INFO completely?
> 
> I'm also not keen on adding workarounds for old, beta, or release
> candidate firmware.

I should be safe to remove this; one of the only reasons I was doing
it (if memory serves) was as a kind of an "ack" of the firmware being
up and running (if the command worked, we were gold).

Maybe it could be replaced with an WUSB1.0 standard command for performing
the same kind of check, some command that has no secondary effects,
like DEV_ADDR.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html