Re: [RFC/PATCH] USB reset on atomic context (v2)

On Wednesday 13 August 2008, Pete Zaitcev wrote:
> On Wed, 13 Aug 2008 13:55:46 -0700, Inaky Perez-Gonzalez <inaky-VuQAYsv1563Yd54FQh9/[email protected]> wrote:
> 
> > +	did_lock = result < 0 ? 0 : 1;
> 
> Isn't this a strangely convoluted way to write 
> 	did_lock = result >= 0;

ack to that....

> I'm looking at what you're doing with great interest, because of
> ub_reset_task(). But I cannot jump on the bandwagon just yet,
> because ub wants to know when an oustanding reset exists, and
> therefore it needs a notification of reset end. Maybe for WUSB
> it's enough to fire a reset request and forget it happened.

We could add code for that:

usb_queue_reset_pending(udev) 
{
	return work_pending(&udev->reset_ws);
}

Why does it need to know about an outstanding request, anyway?

We could add something to __usb_queue_reset() for notification,
something like waking up a wait queue (udev->reset_wq). Would that work
for you?


-- 
Inaky
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html