Re: [RFC/PATCH] USB reset on atomic context

On Thursday 14 August 2008, David Vrabel wrote:
> Inaky Perez-Gonzalez wrote:
> > On Wednesday 13 August 2008, David Vrabel wrote:
> >> Inaky Perez-Gonzalez wrote:
> >>> Hi All
> >>>
> >>> This patch introduces a new call to be able to do a USB reset
> >>> from an atomic contect. This is quite helpful in USB callbacks
> >>> to handle errors (when the only thing that can be done is to
> >>> do a device reset). The Wireless USB code for using wire adaptors
> >>> needs this functionality.
> >> I've since changed how resets are handled in the UWB/WUSB code and this
> >> is no longer necessary for HWAs (reset requests go via the UWB stack
> >> which carries them in out in the uwbd thread).
> > 
> > Ouch...doesn't that make the error handling more twisted? Where do you have
> > the code so i can take a look?
> 
> It's not so bad.  The attached patch gives you some idea of the changes.
>  Most of them are related to the changes to the struct uwb_event.
> 
> I also think it makes more sense as it will allow the RC to inform PALs
> of impending resets in a h/w independent way (the code does make any use
> of this yet).

Oh, I see what you mean -- out of couriosity could the same effect be 
achievable with pre_reset() handlers for PALs that are hanging out of
that same USB device? [granted, that'd not work for PCI based ones].

-- 
Inaky
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html