Re: [ANNOUNCE] VDR version 2.7.5 released

Hi, IMHO skincurses plugin also does not compile:


*** Plugin skincurses:
...
...

skincurses.c:In member function =E2=80=98virtual void
cSkinCursesDisplayTracks::SetAudioChannel(int)=E2=80=99:
skincurses.c:650:52:error: =E2=80=98override=E2=80=99 was not declared in =
this scope;
did you mean =E2=80=98overwrite=E2=80=99?
 =C2=A0650 | =C2=A0=C2=A0virtual void SetAudioChannel(int AudioChannel) { =
override}
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| ^~~~~~~~
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| overwrite
skincurses.c:In member function =E2=80=98virtual const char*
cPluginSkinCurses::MainMenuEntry()=E2=80=99:
skincurses.c:802:72:error: =E2=80=98override=E2=80=99 was not declared in =
this scope;
did you mean =E2=80=98overwrite=E2=80=99?
 =C2=A0802 | =C2=A0=C2=A0virtual const char *MainMenuEntry(void) { return
tr(MAINMENUENTRY); override}
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| ^~~~~~~~
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| overwrite

Greetings from Berlin

Martin


Am 13.04.25 um 16:01 schrieb Marko M=C3=A4kel=C3=A4:
> Sat, Apr 12, 2025 at 12:46:46PM +0200, Klaus Schmidinger wrote:
>> Added the "override" keyword to virtual functions reimplemented in
>> derived classes.
>
> This C++11 keyword is misplaced in the plugin "hello". Here is the
> first misplaced occurrence:
>
> hello.c: In member function =E2=80=98virtual const char*
> cPluginHello::Version()=E2=80=99:
> hello.c:27:56: error: =E2=80=98override=E2=80=99 was not declared in thi=
s scope
> =C2=A0=C2=A0 27 |=C2=A0=C2=A0 virtual const char *Version(void) { return=
 VERSION; override}
>
> The keyword "override" should occur before the function body, not in
> the body.=C2=A0 To my understanding, the keyword "virtual" is redundant =
and
> could be removed, because "override" alone should imply that it is a
> virtual member function.
>
> Other than this, I was able to build and install the upgrade.
>
> With best regards,
>
> =C2=A0=C2=A0=C2=A0=C2=A0Marko