Re: (Fwd) [patch] wolk4.5s panic.c

On Tuesday 05 August 2003 16:28, [email protected] wrote:

Hi Michael,

> this [0]is a patch for kernel/panic.c.
> because wolk4.5 wont compile without watchdog support, this patch was
> created in irc (kerframil and me).
> [0]: http://members.aon.at/einstein/patch-panic.c
> [1]: http://members.aon.at/einstein/patch-page_alloc.c

well, [0] is wrong because of:

touch_nmi_watchdog is NMI watchdog, _not_ watchdog support. NMI watchdog is 
only compiled in if you select "CONFIG_X86_LOCAL_APIC"

and [1] is wrong because of, see:

        if (page->pte.direct)
                printk(KERN_WARNING "blalblala!\n");
                printk(KERN_WARNING "blabllbllblbl.\n");
                BUG();

So what do we have here? right.

1. an if condition and right after it a printk.
2. Afer (1) there's another printk w/o an if condition
3. After (1+2) there's a BUG() w/o an if condition

So what does this mean? Yeah, the BUG() is always there :P
Some gcc's should fix this properly but some won't. Afaik gcc 2.95.4 does it 
wrong, gcc 3.3.1 does it wrong, gcc 3.2.3 does it right.

Now you might ask, how does it look right? Use this:

        if (page->pte.direct) {
                printk(KERN_WARNING "blalblala!\n");
                printk(KERN_WARNING "blabllbllblbl.\n");
                BUG();
        }

Anyway, I'll release wolk4.6 in some minutes with some of the fixes from you 
Michael. Thanks for them. P.S.: If you say OK to the grsec randid stuff, send 
it to me and I'll include it :)

ciao, Marc



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
WOLK - Working Overloaded Linux Kernel
[email protected]
https://lists.sourceforge.net/lists/listinfo/wolk-devel