Re: 2.6.3-wolk1.0 compile error (EXT3_FS_POSIX_ACL wants EXT2_FS_XATTR?)

On Friday 27 February 2004 14:42, Kerin Millar wrote:

Hi Kerin,

> Granted, this is almost certainly an -mm bug. Anyway, my first attempt at
> compiling 2.6.3-wolk1.0 crapped out as follows:
> fs/built-in.o(.text+0x7ee97): In function `ext3_get_acl':
> : undefined reference to `ext2_xattr_get'
> fs/built-in.o(.text+0x7eee4): In function `ext3_get_acl':
> : undefined reference to `ext2_xattr_get'
oooops.

> Fine, it was easily resolved by enabling CONFIG_EXT2_FS_XATTR. This seems
> braindead to me. The same issue does not occur with vanilla 2.6.3 or
> gentoo-dev-sources. Here's the relevant part of my .config which causes it
> to fail.
That is braindead, because I did a typo ;)

try attached patch. It's non an -mm issue, it's a -wolk issue.

ciao, Marc

--- wolk1.0/fs/ext3/acl.c	2004-02-26 12:19:11.000000000 +0100
+++ wolk1.1/fs/ext3/acl.c	2004-02-27 19:45:09.000000000 +0100
@@ -184,12 +184,12 @@ ext3_get_acl(struct inode *inode, int ty
 		default:
 			return ERR_PTR(-EINVAL);
 	}
-	retval = ext2_xattr_get(inode, name_index, "", NULL, 0);
+	retval = ext3_xattr_get(inode, name_index, "", NULL, 0);
 	if (retval > 0) {
 		value = kmalloc(retval, GFP_KERNEL);
 		if (!value)
 			return ERR_PTR(-ENOMEM);
-		retval = ext2_xattr_get(inode, name_index, "", value, retval);
+		retval = ext3_xattr_get(inode, name_index, "", value, retval);
 	}
 	if (retval > 0)
 		acl = ext3_acl_from_disk(value, retval);