Re: ASDF-INSTALL:UNINSTALL doesn't remove .asd symlinks (Linux)

On Dec 19, 2005, at 11:42 PM, Gary King wrote:

> Hi,
>
> Here is a suggested patch for _part_ of the problem Paolo has found. 
> the patch only handles the ASDF part of the issue, not the 
> MK-DEFSYSTEM part.

This seems like an overkill to me.  It assumes that all the system 
files in the directory are part of the system.  While this is usually 
true, it is not foolproof.

The MK:DEFSYSTEM part explicitly uses the introspective facilities 
(MK:FILES-IN-SYSTEM) and thus it cleans only what it's in the system.  
In some ways is much more conservative, but it works as advertised.

The problem is that in general

	<tarball> /= <asdf, mk-defsystem system>


>
> 757,766c667,669
> <          (system (asdf:find-system system))
> <          (dir (asdf::pathname-sans-name+type
> <                (asdf::resolve-symlinks asd)))
> <          (wild-source (make-pathname :directory (namestring dir)

Incidentally, using :directory (namestring dir) is not quite kosher 
(also below in the patch).

Cheers

Marco










> <                                      :name :wild
> <                                      :type "asd"))
> <          (wild-target (make-pathname :name :wild
> <                                      :type "asd"
> <                                      :directory 
> (directory-namestring asd)))
> <          (systems (directory wild-source)))
> ---
> >        (system (asdf:find-system system))
> >        (dir (asdf::pathname-sans-name+type
> >              (asdf::resolve-symlinks asd))))
> 768,770c671,673
> <               (y-or-n-p
> <                "Delete system ~A~%asd file: ~A~%sources: ~A~%Are you 
> sure?"
> <                system asd dir))
> ---
> >             (y-or-n-p
> >              "Delete system ~A~%asd file: ~A~%sources: ~A~%Are you 
> sure?"
> >              system asd dir))
> 772,776c675,677
> <       (dolist (file systems)
> <         (let ((link (translate-pathname file wild-source 
> wild-target)))
> <           (delete-file link)))
> <       (asdf:run-shell-command "rm -r ~A" (namestring dir))))
> <
> ---
> >       (delete-file asd)
> >       (asdf:run-shell-command "rm -r '~A'" (namestring (truename 
> dir)))))
> >
>
> HTH,
>
> On Dec 18, 2005, at 5:22 AM, Paolo Amoroso wrote:
>
>> Paolo Amoroso <[email protected]> writes:
>>
>>> Paolo Amoroso <[email protected]> writes:
>>>
>>>> I have installed the latest CVS version of ASDF-INSTALL.  When I
>>>> uninstall an application with ASDF-INSTALL:UNINSTALL the source
>>>> directory is removed correctly, but not the symlink in the systems
>>>> directory.  My ~/.asdf-install contains:
>>>
>>> It looks like this happens only with CL-PPCRE.  The removal of .asd
>>> files for other applications I have tried works correctly.
>>
>> More specifically, when there is more than one .asd file, only the one
>> with the application name is removed.  CL-PPCRE, for example, comes
>> with the following .asd files:
>>
>>   cl-ppcre-test.asd
>>   cl-ppcre-test.system
>>   cl-ppcre.asd
>>   cl-ppcre.system
>>
>> and only cl-ppcre.asd is removed.
>>
>>
>> Paolo
>> -- 
>> Lisp Propulsion Laboratory log - http://www.paoloamoroso.it/log
>>
>>
>> -------------------------------------------------------
>> This SF.net email is sponsored by: Splunk Inc. Do you grep through 
>> log files
>> for problems?  Stop!  Download the new AJAX search engine that makes
>> searching your log files as easy as surfing the  web.  DOWNLOAD 
>> SPLUNK!
>> http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
>> _______________________________________________
>> cclan-list mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/cclan-list
>
>
> -- 
> Gary Warren King
> metabang.com
> http://www.metabang.com/
>
>
>
--
Marco Antoniotti					http://bioinformatics.nyu.edu/~marcoxa
NYU Courant Bioinformatics Group		tel. +1 - 212 - 998 3488
715 Broadway 10th FL				fax. +1 - 212 - 998 3484
New York, NY, 10003, U.S.A.



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click