Re: [Sbcl-devel] [PATCH] ASDF: .fasl and .lisp in sync when mtime is equal

Andreas Fuchs <[email protected]> Fri, 30 Nov 2007 13:07:59 +0100
Newsgroups gmane.lisp.cclan.general
Message-ID <[email protected]>
On Nov 30, 2007, at 11:57, Johannes Weiner wrote:
> --- asdf/asdf.lisp.~1.110.~	2007-09-27 15:15:06.000000000 +0200
> +++ asdf/asdf.lisp	2007-11-29 15:03:44.000000000 +0100
> @@ -644,8 +644,8 @@
>             (t
>              (and
>               (every #'probe-file out-files)
> -              (> (apply #'min (mapcar #'file-write-date out-files))
> -                 (apply #'max (mapcar #'fwd-or-return-t in- 
> files)))))))))
> +              (>= (apply #'min (mapcar #'file-write-date out-files))
> +                  (apply #'max (mapcar #'fwd-or-return-t in- 
> files)))))))))


I'm sure we can agree on CRUX linux being at fault here (touching  
files when installing them strikes me as a very odd thing to do), but  
I don't think this patch is the way to go.

It's somewhat easy to (manually, even) save a lisp file in the same  
second its .fasl file is written, which will make ASDF think the file  
is up to date while it really isn't. So, I'd prefer to keep that check  
at a strict #'>, and fix CRUX Linux only.

Cheers,
-- 
Andreas Fuchs, (http://|im:asf@|mailto:asf@)boinkor.net, antifuchs


-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell.  From the desktop to the data center, Linux is going
mainstream.  Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4