Re: [PATCH] have OPERATION-DONE-P return NIL for TEST-OP by default

I'd like to commit this; is there any dissent?

On Dec 10, 2007, at 7:50 PM, Luis Oliveira wrote:

> Gary King <[email protected]> writes:
>> however, that I'd prefer to dispatch only on systems, not components
>> (only because it seems more minimal). I'm also less convinced about
>> the component-depends-on method. Maybe that should also go only for
>> systems. Either way, if these are documented, it shouldn't be a
>> problem for people to override them as needed. (Though that should be
>> tested).
>
> That makes sense to me.  The attached patch does that instead.
>
> Index: asdf.lisp
> ===================================================================
> RCS file: /cvsroot/cclan/asdf/asdf.lisp,v
> retrieving revision 1.110
> diff -u -r1.110 asdf.lisp
> --- asdf.lisp	27 Sep 2007 13:15:06 -0000	1.110
> +++ asdf.lisp	11 Dec 2007 00:01:30 -0000
> @@ -861,6 +861,9 @@
> (defmethod perform ((operation test-op) (c component))
>   nil)
>
> +(defmethod operation-done-p ((operation test-op) (c system))
> +  nil)
> +
> (defgeneric load-preferences (system operation)
>   (:documentation "Called to load system preferences after <perform  
> operation system>. Typical uses are to set parameters that don't  
> exist until after the system has been loaded."))
>
>
> -- 
> Luís Oliveira
> http://student.dei.uc.pt/~lmoliv/
> -------------------------------------------------------------------------
> SF.Net email is sponsored by:
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php_______________________________________________
> cclan-list mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/cclan-list

--
Gary Warren King, metabang.com
Cell: (413) 559 8738
Fax: (206) 338-4052
gwkkwg on Skype * garethsan on AIM





-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/