Re: Getting rid of varbrace
Sam Steingold <[email protected]>
| Newsgroups | gmane.lisp.clisp.devel |
|---|---|
| Message-ID | <[email protected]> |
Daniel, I will leave installing the patch to Bruno because this is a portability issue. However, I have some comments inline below. > * Daniel Jour <[email protected]> [2017-03-21 01:01:13 +0000]: > > - Contain no comment what the #define var does and why its there. Not good. Given that we have almost 12k "var" instances: --8<---------------cut here---------------start------------->8--- $ grep '^ *var ' *.d | wc -l 11760 --8<---------------cut here---------------end--------------->8--- we need either a comment or a thorough purge. I favor the latter because I want the CLISP sources to _look_ like regular C. Note that the purge can be done with a perl one-liner. > - Don't mention any change in the change log. Bruno will be irate :-) > - Remove an (hopefully!) unused variable. This should probably be a > separate commit. Absolutely. Please either make a separate patch or tell me where the unused var is. > - Manually add a pairs of braces at two places; I couldn't figure out what > exactly the code there does, so I went the safe route. Why did you need the braces at all? > Most of the compilation errors complained about having only a declaration > following an (goto) label. I solved this by adding a semicolon behind each > such label ("label:" becomse "label:;"). No, please add braces instead. > Is this a viable approach at getting rid of varbrace soon? If so then > I can "polish" those patches further. I will let Bruno decide on this. -- Sam Steingold (http://sds.podval.org/) on darwin Ns 10.3.1504 http://steingoldpsychology.com http://www.childpsy.net http://www.memritv.org http://memri.org http://honestreporting.com http://think-israel.org Don't take life too seriously, you'll never get out of it alive! ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ clisp-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/clisp-devel